add explicit version check

dagster-io · Jan 27, 2023 · d85600f · d85600f
1 parent 7b14016
commit d85600f
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/python_modules/libraries/dagster-mysql/dagster_mysql_tests/test_run_storage.py b/python_modules/libraries/dagster-mysql/dagster_mysql_tests/test_run_storage.py
@@ -4,6 +4,7 @@
 import yaml
 from dagster._core.test_utils import environ, instance_for_test
 from dagster_mysql.run_storage import MySQLRunStorage
+from dagster_mysql.utils import parse_mysql_version
 from dagster_tests.storage_tests.utils.run_storage import TestRunStorage
 
 TestRunStorage.__test__ = False
@@ -92,6 +93,7 @@ def get_server_version(self):
             return "5.7.38-log"
 
     storage = FakeNonBucketing(conn_string)
+    assert parse_mysql_version("5.7.38-log") == (5, 7, 38)
     assert not storage.supports_bucket_queries
 
     class FakeBucketing(MySQLRunStorage):
@@ -100,4 +102,5 @@ def get_server_version(self):
             return "8.0.31-google"
 
     storage = FakeBucketing(conn_string)
+    assert parse_mysql_version("8.0.31-google") == (8, 0, 31)
     assert storage.supports_bucket_queries