Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[daggy-u] [dbt] - Polishing #20254

Merged
merged 14 commits into from
Mar 6, 2024
Merged

[daggy-u] [dbt] - Polishing #20254

merged 14 commits into from
Mar 6, 2024

Conversation

erinkcochran87
Copy link
Contributor

Summary & Motivation

This PR does a bunch of things:

  • Adds screenshots
  • Cleans up some copy and errors
  • Removes an unneeded section in Lesson 6

How I Tested These Changes

@erinkcochran87 erinkcochran87 added the area: dagster-university Related to Dagster University label Mar 5, 2024
Copy link

github-actions bot commented Mar 5, 2024

Deploy preview for dagster-university ready!

✅ Preview
https://dagster-university-mjxj80ubl-elementl.vercel.app
https://erin-du-dbt-cleanup.dagster-university.dagster-docs.io

Built with commit 425da3c.
This pull request is being automatically deployed with vercel-action

Copy link

github-actions bot commented Mar 5, 2024

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-jpbue2sl2-elementl.vercel.app
https://erin-du-dbt-cleanup.dagster.dagster-docs.io

Direct link to changed pages:

@@ -99,12 +99,12 @@ The following table contains the environment variables we need to create in Dags
---

- `DUCKDB_DATABASE`
- todo
- The service token for a Motherduck database, formatted as `md:?motherduck_token=<insert_token_here>`. Refer to the [Motherduck documentation](https://motherduck.com/docs/authenticating-to-motherduck/#authentication-using-a-service-token) for more info.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that is accurate!

@erinkcochran87
Copy link
Contributor Author

@tacastillo @cmpadden This PR looks big but it's just a bunch of small changes and screenshots.

Copy link
Contributor

@cmpadden cmpadden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good. Nice work, Erin.

I find the revisions on connecting Dagster and dbt model assets to be much more clear.

@erinkcochran87 erinkcochran87 merged commit cfa9d87 into master Mar 6, 2024
2 checks passed
@erinkcochran87 erinkcochran87 deleted the erin/du-dbt-cleanup branch March 6, 2024 16:06
PedramNavid pushed a commit that referenced this pull request Mar 28, 2024
## Summary & Motivation

This PR does a bunch of things:

- Adds screenshots
- Cleans up some copy and errors
- Removes an unneeded section in Lesson 6

## How I Tested These Changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dagster-university Related to Dagster University
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants