Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimize workspace snapshot dependency from GrapheneAssetLatestInfo #21764

Closed
wants to merge 1 commit into from
Closed

Minimize workspace snapshot dependency from GrapheneAssetLatestInfo #21764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 46 additions & 33 deletions python_modules/dagster-graphql/dagster_graphql/implementation/fetch_runs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,31 +161,25 @@ def get_run_ids(

def get_assets_latest_info(
graphene_info: "ResolveInfo",
step_keys_by_asset: Mapping[AssetKey, Sequence[str]],
asset_keys: AbstractSet[AssetKey],
asset_record_loader: "BatchAssetRecordLoader",
) -> Sequence["GrapheneAssetLatestInfo"]:
from dagster_graphql.implementation.fetch_assets import get_asset_nodes_by_asset_key

from ..schema.asset_graph import GrapheneAssetLatestInfo
from ..schema.logs.events import GrapheneMaterializationEvent
from ..schema.pipelines.pipeline import GrapheneRun

instance = graphene_info.context.instance

asset_keys = list(step_keys_by_asset.keys())

if not asset_keys:
return []

asset_nodes = get_asset_nodes_by_asset_key(graphene_info, set(asset_keys))

asset_records = asset_record_loader.get_asset_records(asset_keys)
asset_records = asset_record_loader.get_asset_records(list(asset_keys))

latest_materialization_by_asset = {
asset_record.asset_entry.asset_key: (
GrapheneMaterializationEvent(event=asset_record.asset_entry.last_materialization)
if asset_record.asset_entry.last_materialization
and asset_record.asset_entry.asset_key in step_keys_by_asset
and asset_record.asset_entry.asset_key in asset_keys
else None
)
for asset_record in asset_records
Expand All @@ -198,7 +192,7 @@ def get_assets_latest_info(
asset_record.asset_entry.asset_key: (
asset_record.asset_entry.last_materialization.run_id
if asset_record.asset_entry.last_materialization
and asset_record.asset_entry.asset_key in step_keys_by_asset
and asset_record.asset_entry.asset_key in asset_keys
else None
)
for asset_record in asset_records
Expand All @@ -212,39 +206,30 @@ def get_assets_latest_info(
if asset_record.asset_entry.last_run_id
}

run_records_by_run_id = {}
in_progress_records = []
run_ids = list(set(latest_run_ids_by_asset.values())) if latest_run_ids_by_asset else []
if run_ids:
run_records = instance.get_run_records(RunsFilter(run_ids=run_ids))
for run_record in run_records:
if run_record.dagster_run.status in PENDING_STATUSES:
in_progress_records.append(run_record)
run_records_by_run_id[run_record.dagster_run.run_id] = run_record
run_records = instance.get_run_records(RunsFilter(run_ids=run_ids)) if run_ids else []

run_records_by_run_id = {}

for run_record in run_records:
run_records_by_run_id[run_record.dagster_run.run_id] = run_record

(
in_progress_run_ids_by_asset,
unstarted_run_ids_by_asset,
) = _get_in_progress_runs_for_assets(
graphene_info,
in_progress_records,
step_keys_by_asset,
asset_keys,
run_records_by_run_id,
latest_materialization_run_id_by_asset,
latest_run_ids_by_asset,
)

from .fetch_assets import get_unique_asset_id

return [
GrapheneAssetLatestInfo(
(
get_unique_asset_id(
asset_key,
asset_nodes[asset_key].repository_location.name,
asset_nodes[asset_key].external_repository.name,
)
if asset_nodes[asset_key]
else get_unique_asset_id(asset_key)
),
get_unique_asset_id(asset_key),
asset_key,
latest_materialization_by_asset.get(asset_key),
list(unstarted_run_ids_by_asset.get(asset_key, [])),
Expand All @@ -258,16 +243,43 @@ def get_assets_latest_info(
else None
),
)
for asset_key in step_keys_by_asset.keys()
for asset_key in asset_keys
]


def _get_in_progress_runs_for_assets(
graphene_info: "ResolveInfo",
in_progress_records: Sequence[RunRecord],
step_keys_by_asset: Mapping[AssetKey, Sequence[str]],
asset_keys: AbstractSet[AssetKey],
run_records_by_run_id: Dict[str, RunRecord],
latest_materialization_run_id_by_asset: Dict[AssetKey, Optional[str]],
latest_run_ids_by_asset: Dict[AssetKey, str],
) -> Tuple[Mapping[AssetKey, AbstractSet[str]], Mapping[AssetKey, AbstractSet[str]]]:
from dagster_graphql.implementation.fetch_assets import get_asset_nodes_by_asset_key

in_progress_run_ids = set()

for run_id, run_record in run_records_by_run_id.items():
if run_record.dagster_run.status in PENDING_STATUSES:
in_progress_run_ids.add(run_id)

# Load nodes for the asset keys whose most recent run is in progress
asset_keys_with_in_progress_runs = {
asset_key
for asset_key in asset_keys
if latest_run_ids_by_asset.get(asset_key) in in_progress_run_ids
}

asset_nodes = (
get_asset_nodes_by_asset_key(graphene_info, asset_keys_with_in_progress_runs)
if asset_keys_with_in_progress_runs
else {}
)

# Build mapping of asset key to the step keys required to generate the asset
step_keys_by_asset = {
asset_key: node.external_asset_node.op_names for asset_key, node in asset_nodes.items()
}

# Build mapping of step key to the assets it generates
asset_key_by_step_key = defaultdict(set)
for asset_key, step_keys in step_keys_by_asset.items():
Expand All @@ -277,7 +289,8 @@ def _get_in_progress_runs_for_assets(
in_progress_run_ids_by_asset = defaultdict(set)
unstarted_run_ids_by_asset = defaultdict(set)

for record in in_progress_records:
for run_id in in_progress_run_ids:
record = run_records_by_run_id[run_id]
run = record.dagster_run
asset_selection = run.asset_selection
run_step_keys = graphene_info.context.instance.get_execution_plan_snapshot(
Expand Down
14 changes: 2 additions & 12 deletions python_modules/dagster-graphql/dagster_graphql/schema/roots/query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from typing import Any, Dict, List, Mapping, Optional, Sequence, cast
from typing import Any, List, Mapping, Optional, Sequence, cast

import dagster._check as check
import graphene
Expand Down Expand Up @@ -1076,20 +1076,10 @@ def resolve_assetsLatestInfo(
):
asset_keys = set(AssetKey.from_graphql_input(asset_key) for asset_key in assetKeys)

results = get_asset_nodes(graphene_info, asset_keys)

# Filter down to requested asset keys
# Build mapping of asset key to the step keys required to generate the asset
step_keys_by_asset: Dict[AssetKey, Sequence[str]] = {
node.external_asset_node.asset_key: node.external_asset_node.op_names
for node in results
if node.assetKey in asset_keys
}

asset_record_loader = graphene_info.context.asset_record_loader
asset_record_loader.add_asset_keys(asset_keys)

return get_assets_latest_info(graphene_info, step_keys_by_asset, asset_record_loader)
return get_assets_latest_info(graphene_info, asset_keys, asset_record_loader)

@capture_error
def resolve_logsForRun(
Expand Down