Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move compute logs utility scripts #21944

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

mlarose
Copy link
Contributor

@mlarose mlarose commented May 17, 2024

Summary & Motivation

Relates to #21920

How I Tested These Changes

Tested with ./examples/deploy_docker/from_source/build.sh docker-compose set + launching a run to verify the problem is addressed

@mlarose mlarose marked this pull request as ready for review May 17, 2024 18:47
@mlarose mlarose requested a review from gibsondan May 17, 2024 18:47
@mlarose mlarose changed the title mlarose/move-watch-orphans-script Move compute logs utility scripts May 17, 2024
@gibsondan gibsondan requested a review from prha May 20, 2024 21:32
@gibsondan
Copy link
Member

seems reasonable to me, there may also be a way to invoke the script so that it doesn't try to pick up local imports? Maybe by invoking it as a module with -m rather than as a file? but this solution requires less knowledge of python arcana so is probably worth doing either way

@mlarose
Copy link
Contributor Author

mlarose commented May 20, 2024

seems reasonable to me, there may also be a way to invoke the script so that it doesn't try to pick up local imports? Maybe by invoking it as a module with -m rather than as a file? but this solution requires less knowledge of python arcana so is probably worth doing either way

Short answer, I don't know. I don't see the advantage over a different loading method vs just segregating the offenders in their own folder, and I wanted to fix quickly in case a hotfix was deemed necessary.

I like the fact that I am isolating scripts that aren't really part of the code that should be loaded in the module in their own folder. the only reason there is an __init__.py is because how the path is discovered (import then .file)

Copy link
Member

@prha prha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

@mlarose mlarose merged commit d349467 into master May 21, 2024
1 check passed
@mlarose mlarose deleted the mlarose/move-watch-orphans-script branch May 21, 2024 17:58
nikomancy pushed a commit that referenced this pull request May 22, 2024
## Summary & Motivation

Relates to #21920

## How I Tested These Changes

Tested with ./examples/deploy_docker/from_source/build.sh docker-compose
set + launching a run to verify the problem is addressed
danielgafni pushed a commit to danielgafni/dagster that referenced this pull request Jun 18, 2024
## Summary & Motivation

Relates to dagster-io#21920

## How I Tested These Changes

Tested with ./examples/deploy_docker/from_source/build.sh docker-compose
set + launching a run to verify the problem is addressed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants