Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] - Add guide for schedule timezone execution (DOC-238) #22034

Merged
merged 5 commits into from
May 22, 2024
Merged

[docs] - Add guide for schedule timezone execution (DOC-238) #22034

merged 5 commits into from
May 22, 2024

Conversation

erinkcochran87
Copy link
Contributor

Summary & Motivation

This PR splits the timezone content in the Schedules concept page out into its own guide.

How I Tested These Changes

eyes, local, dagster dev for examples

@graphite-app graphite-app bot added the area: docs Related to documentation in general label May 22, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 22, 2024 •
edited
Loading

Deploy preview for dagster-docs ready!

Preview available at https://dagster-docs-pknl6ejkq-elementl.vercel.app
https://erin-doc-238-schedule-timezones.dagster.dagster-docs.io

Direct link to changed pages:

tacastillo
tacastillo approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@tacastillo tacastillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR splits the timezone content in the Schedules concept page out into its own guide.

Does this mean there's somewhere else where this content exists and should be deleted at some point?

This looks good and is really helpful! Stamping!

@erinkcochran87
Copy link
Contributor Author

Does this mean there's somewhere else where this content exists and should be deleted at some point?

@tacastillo Yes! When I re-do the Schedules concept page, I'll remove it then.

@erinkcochran87 erinkcochran87 merged commit b596be9 into master May 22, 2024
2 checks passed
@erinkcochran87 erinkcochran87 deleted the erin/doc-238-schedule-timezones branch May 22, 2024 20:05
danielgafni pushed a commit to danielgafni/dagster that referenced this pull request Jun 18, 2024
@erinkcochran87 @danielgafni
[docs] - Add guide for schedule timezone execution (DOC-238) (dagster…
c8d8e8a 
…-io#22034)

## Summary & Motivation

This PR splits the timezone content in the Schedules concept page out
into its own guide.

## How I Tested These Changes

eyes, local, `dagster dev` for examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacastillo tacastillo tacastillo approved these changes

@cmpadden cmpadden Awaiting requested review from cmpadden

Assignees
No one assigned
Labels
area: docs Related to documentation in general
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erinkcochran87 @tacastillo