Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dagster-deltalake] Fix GcsConfig() ImportError and TypeError for partitioned assets #22054

Merged
merged 3 commits into from
Jun 3, 2024
Merged

[dagster-deltalake] Fix GcsConfig() ImportError and TypeError for partitioned assets #22054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc97566
fix: add missing GcsConfig import
thmswt May 23, 2024
ea5f234
fix: remove keyword argument key
thmswt May 23, 2024
9d5123c
refactor: sort imports
thmswt Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions python_modules/libraries/dagster-deltalake/dagster_deltalake/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

from .config import (
AzureConfig as AzureConfig,
GcsConfig as GcsConfig,
LocalConfig as LocalConfig,
S3Config as S3Config,
)
Expand Down
2 changes: 1 addition & 1 deletion python_modules/libraries/dagster-deltalake/dagster_deltalake/handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,6 @@ def _table_reader(table_slice: TableSlice, connection: TableConnection) -> ds.Da

dataset = table.to_pyarrow_dataset()
if partition_expr is not None:
dataset = dataset.filter(expression=partition_expr)
dataset = dataset.filter(partition_expr)

return dataset