[ui][global search] Set up useAugmentSearchResults in CloudOSSContext
#22072
Conversation
…rt search by user name
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @benpankow and the rest of your teammates on |
benpankow
requested review from
salazarm,
clairelin135 and
hellendag
and removed request for
salazarm
|
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit c0634a8. |
| @@ -12,6 +12,17 @@ type LaunchpadHooksContextValue = { | |||
| LaunchRootExecutionButton?: typeof LaunchRootExecutionButton; | |||
| useLaunchWithTelemetry?: typeof useLaunchWithTelemetry; | |||
| UserDisplay?: typeof UserDisplay; | |||
| useAllUserDetails?: () => { | |||
There was a problem hiding this comment.
We have so many contexts that do this kind of injection 😅 . I would recommend CloudOSSContext but uhh it really doesnt matter (Right now). In the future it would matter for page split bundling but there would be other things to figure out then anyways
There was a problem hiding this comment.
Oh good call, I was blindly following UserDisplay 😅
js_modules/dagster-ui/packages/ui-core/src/search/useGlobalSearch.tsx
Outdated
Show resolved
Hide resolved
benpankow
changed the title
useAugmentSearchResults in CloudOSSContext
…ext` (dagster-io#22072) ## Summary Adds a new entry to `CloudOSSContext` to let us inject a function which can be used to augment global search results. Used in cloud to display users' full names in the search pane. This allows you to search by a user's name in addition to (or in place of) their email. <img width="876" alt="Screenshot 2024-05-23 at 1 49 45 PM" src="https://github.com/dagster-io/dagster/assets/10215173/f204e597-e094-4824-8fb6-a1cf8937e11c"> ## Test Plan Shadow dagit.
Summary
Adds a new entry to
CloudOSSContextto let us inject a function which can be used to augment global search results. Used in cloud to display users' full names in the search pane.This allows you to search by a user's name in addition to (or in place of) their email.
Test Plan
Shadow dagit.