Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Remove asset overview feature flag #22082

Merged

Conversation

clairelin135
Copy link
Contributor

@clairelin135 clairelin135 commented May 23, 2024

The asset overview feature flag gates the new asset details page and the catalog page in internal. This is already set to be "on" by default.

Now that these pages are un-experimentalized, we can remove the feature flag and always rely on these pages.
https://linear.app/dagster-labs/issue/PLUS-1120/remove-asset-overviewcatalog-feature-flags

@clairelin135
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @clairelin135 and the rest of your teammates on Graphite Graphite

Copy link

github-actions bot commented May 23, 2024

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-1l7oitub7-elementl.vercel.app
https://05-23-claire-remove-asset-overview-feature-flag.core-storybook.dagster-docs.io

Built with commit 17ee7d2.
This pull request is being automatically deployed with vercel-action

@clairelin135 clairelin135 force-pushed the 05-23-claire/remove-asset-overview-feature-flag branch 3 times, most recently from 330c13b to d2ec5d7 Compare May 24, 2024 23:28
@clairelin135 clairelin135 changed the title claire/remove-asset-overview-feature-flag Remove asset overview feature flag May 24, 2024
@clairelin135 clairelin135 marked this pull request as ready for review May 24, 2024 23:39
@clairelin135 clairelin135 changed the title Remove asset overview feature flag [ui] Remove asset overview feature flag May 24, 2024
@clairelin135 clairelin135 force-pushed the 05-23-claire/remove-asset-overview-feature-flag branch from d2ec5d7 to 17ee7d2 Compare May 29, 2024 18:37
Copy link

Deploy preview for dagit-storybook ready!

✅ Preview
https://dagit-storybook-7cyvw1sln-elementl.vercel.app
https://05-23-claire-remove-asset-overview-feature-flag.components-storybook.dagster-docs.io

Built with commit 17ee7d2.
This pull request is being automatically deployed with vercel-action

@clairelin135 clairelin135 merged commit cf4cf64 into master May 29, 2024
5 checks passed
@clairelin135 clairelin135 deleted the 05-23-claire/remove-asset-overview-feature-flag branch May 29, 2024 18:54
danielgafni pushed a commit to danielgafni/dagster that referenced this pull request Jun 18, 2024
The asset overview feature flag gates the new asset details page and the
catalog page in internal. This is already set to be "on" by default.

Now that these pages are un-experimentalized, we can remove the feature
flag and always rely on these pages.

https://linear.app/dagster-labs/issue/PLUS-1120/remove-asset-overviewcatalog-feature-flags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants