Remove asset nodes fetch from assetsLatestInfo #22285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibsondan
commented
Jun 4, 2024
Comment on lines
-227
to
-236
| asset_nodes[asset_key].repository_location.name, | ||
| asset_nodes[asset_key].external_repository.name, |
There was a problem hiding this comment.
verified a while back with @salazarm that we don't need this additional specificity in this ID
gibsondan
force-pushed
the
simplifysimplify
branch
from
1a4dadb
to
f32e2a6
Compare
gibsondan
force-pushed
the
simplifysimplify2
branch
from
bac3fb9
to
a15bdee
Compare
OwenKephart
approved these changes
Jun 4, 2024
gibsondan
force-pushed
the
simplifysimplify
branch
6 times, most recently
from
cdc5785
to
0778133
Compare
Summary: This doesn't give us much in practice since assetsLatestInfo is fetched in parallel with assetNodes currently, but paves the way to make assetsLatestInfo the field that has no asset graph dependencies. Test Plan: BK
gibsondan
force-pushed
the
simplifysimplify2
branch
from
a15bdee
to
c5a9812
Compare
salazarm
pushed a commit
that referenced
this pull request
Jun 10, 2024
Summary: This doesn't give us much in practice since assetsLatestInfo is fetched in parallel with assetNodes currently, but paves the way to make assetsLatestInfo the field that has no asset graph dependencies. Test Plan: BK ## Summary & Motivation ## How I Tested These Changes
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jun 18, 2024
Summary: This doesn't give us much in practice since assetsLatestInfo is fetched in parallel with assetNodes currently, but paves the way to make assetsLatestInfo the field that has no asset graph dependencies. Test Plan: BK ## Summary & Motivation ## How I Tested These Changes
gibsondan
added a commit
that referenced
this pull request
Jul 18, 2024
This reverts commit 6d6654b. The frontend currently depends on this returning nothing if the asset is not in the graph, and its not currently providing any performacnce benefits. Test Plan: Bk
gibsondan
added a commit
that referenced
this pull request
Jul 18, 2024
) This reverts commit 6d6654b. The frontend currently depends on this returning nothing if the asset is not in the graph, and its not currently providing any performacnce benefits. Test Plan: Bk ## Summary & Motivation ## How I Tested These Changes
smackesey
pushed a commit
that referenced
this pull request
Jul 23, 2024
) This reverts commit 6d6654b. The frontend currently depends on this returning nothing if the asset is not in the graph, and its not currently providing any performacnce benefits. Test Plan: Bk ## Summary & Motivation ## How I Tested These Changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This doesn't give us much in practice since assetsLatestInfo is fetched in parallel with assetNodes currently, but paves the way to make assetsLatestInfo the field that has no asset graph dependencies.
Test Plan: BK
Summary & Motivation
How I Tested These Changes