Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Run Timeline splitting out ad hoc jobs #22520

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

salazarm
Copy link
Contributor

@salazarm salazarm commented Jun 13, 2024

Summary & Motivation

https://dagsterlabs.slack.com/archives/C070G3UNNLW/p1718238323769339?thread_ts=1718238288.884269&cid=C070G3UNNLW

before: multiple rows for adhoc materializations
Screenshot 2024-06-12 at 8 36 48 PM

after: just a single one:
Screenshot 2024-06-12 at 8 37 01 PM

Copy link

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-3keu1du1h-elementl.vercel.app
https://salazarm-fix-run-timeline-splitting-out-asset-jobs.core-storybook.dagster-docs.io

Built with commit c7345e8.
This pull request is being automatically deployed with vercel-action

@braunjj braunjj self-requested a review June 13, 2024 00:38
Copy link
Contributor

@braunjj braunjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@salazarm salazarm merged commit 6170b02 into master Jun 13, 2024
2 checks passed
@salazarm salazarm deleted the salazarm/fix-run-timeline-splitting-out-asset-jobs branch June 13, 2024 00:39
salazarm added a commit that referenced this pull request Jun 13, 2024
## Summary & Motivation


https://dagsterlabs.slack.com/archives/C070G3UNNLW/p1718238323769339?thread_ts=1718238288.884269&cid=C070G3UNNLW


before: multiple rows for adhoc materializations
<img width="1332" alt="Screenshot 2024-06-12 at 8 36 48 PM"
src="https://github.com/dagster-io/dagster/assets/2286579/b0310a78-465c-42ab-9231-e83cad77ee55">


after: just a single one:
<img width="1579" alt="Screenshot 2024-06-12 at 8 37 01 PM"
src="https://github.com/dagster-io/dagster/assets/2286579/51f4dd24-9005-4958-bdf2-57f633731e29">
cmpadden pushed a commit that referenced this pull request Jun 13, 2024
## Summary & Motivation


https://dagsterlabs.slack.com/archives/C070G3UNNLW/p1718238323769339?thread_ts=1718238288.884269&cid=C070G3UNNLW


before: multiple rows for adhoc materializations
<img width="1332" alt="Screenshot 2024-06-12 at 8 36 48 PM"
src="https://github.com/dagster-io/dagster/assets/2286579/b0310a78-465c-42ab-9231-e83cad77ee55">


after: just a single one:
<img width="1579" alt="Screenshot 2024-06-12 at 8 37 01 PM"
src="https://github.com/dagster-io/dagster/assets/2286579/51f4dd24-9005-4958-bdf2-57f633731e29">
danielgafni pushed a commit to danielgafni/dagster that referenced this pull request Jun 18, 2024
## Summary & Motivation


https://dagsterlabs.slack.com/archives/C070G3UNNLW/p1718238323769339?thread_ts=1718238288.884269&cid=C070G3UNNLW


before: multiple rows for adhoc materializations
<img width="1332" alt="Screenshot 2024-06-12 at 8 36 48 PM"
src="https://github.com/dagster-io/dagster/assets/2286579/b0310a78-465c-42ab-9231-e83cad77ee55">


after: just a single one:
<img width="1579" alt="Screenshot 2024-06-12 at 8 37 01 PM"
src="https://github.com/dagster-io/dagster/assets/2286579/51f4dd24-9005-4958-bdf2-57f633731e29">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants