[ui] show applyLimitPerUniqueValue entries in queue criteria #22536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @alangenfeld and the rest of your teammates on |
alangenfeld
force-pushed
the
al/06-13-_ui_show_applylimitperuniquevalue_entries_in_queue_criteria
branch
from
9c05e57
to
ac5a94d
Compare
salazarm
reviewed
Jun 13, 2024
Comment on lines
128
to
129
| ? `${limit.key}=${JSON.stringify(limit.value)}` | ||
| : `${limit.key}=${limit.value}` |
There was a problem hiding this comment.
Wouldn't JSON.stringify result in the same output even if its not a plain object?
salazarm
approved these changes
Jun 13, 2024
alangenfeld
force-pushed
the
al/06-13-_ui_show_applylimitperuniquevalue_entries_in_queue_criteria
branch
from
ac5a94d
to
95068be
Compare
alangenfeld
deleted the
al/06-13-_ui_show_applylimitperuniquevalue_entries_in_queue_criteria
branch
danielgafni
pushed a commit
to danielgafni/dagster
that referenced
this pull request
Jun 18, 2024
…-io#22536) ## How I Tested These Changes get runs queued against `applyLimitPerUniqueValue` rule, previously not displayed now: 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How I Tested These Changes
get runs queued against
applyLimitPerUniqueValuerule, previously not displayed now: