-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ui] remove run status column on backfills page #23143
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @jamiedemaria and the rest of your teammates on Graphite |
Deploy preview for dagit-core-storybook ready! ✅ Preview Built with commit f38de78. |
71c6a6d
to
f5c99fd
Compare
36759d0
to
60f659b
Compare
f5c99fd
to
0d2f19e
Compare
60f659b
to
b7ee187
Compare
0d2f19e
to
1683b39
Compare
b7ee187
to
0f855d2
Compare
1683b39
to
666e929
Compare
0f855d2
to
7db309e
Compare
666e929
to
15cfbd7
Compare
7db309e
to
17d4f7e
Compare
15cfbd7
to
8a60c65
Compare
17d4f7e
to
77ac001
Compare
8496ed0
to
1f93860
Compare
1f93860
to
f38de78
Compare
Summary & Motivation
The run status column on the backfills page cannot load for asset-job backfills if the backfill policy of the asset changes. This is because we use run tags/db indices to determine the status of each partition. We need to look for different tags with different backfill policies, but dont store what the backfill policy was when the backfill ran.
Rather than try to make the run status column work, we decided to remove the column for these reasons:
How I Tested These Changes