Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] remove run status column on backfills page #23143

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

jamiedemaria
Copy link
Contributor

@jamiedemaria jamiedemaria commented Jul 22, 2024

Summary & Motivation

The run status column on the backfills page cannot load for asset-job backfills if the backfill policy of the asset changes. This is because we use run tags/db indices to determine the status of each partition. We need to look for different tags with different backfill policies, but dont store what the backfill policy was when the backfill ran.

Rather than try to make the run status column work, we decided to remove the column for these reasons:

  1. job-based backfills are less commonly used and a "secondary" feature. We don't show this run status information for pure asset backfills.
  2. there is work being done for jobs to support multiple partition definitions in the future. when that happens, this graphic makes less sense since we'd need to include one bar per partition and that could take up a lot of space.

How I Tested These Changes

Copy link
Contributor Author

jamiedemaria commented Jul 22, 2024

Copy link

github-actions bot commented Jul 22, 2024

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-4s7l7mrok-elementl.vercel.app
https://jamie-backfill-page-run-status-column.core-storybook.dagster-docs.io

Built with commit f38de78.
This pull request is being automatically deployed with vercel-action

@jamiedemaria
Copy link
Contributor Author

@salazarm @bengotow I'd like to note that I'm not very familiar with front end code. I did my best, but definitely could be making some silly mistakes!

@jamiedemaria jamiedemaria force-pushed the jamie/backfill-page-run-status-column branch from 1683b39 to 666e929 Compare July 23, 2024 13:55
@jamiedemaria jamiedemaria force-pushed the jamie/backfill-page-run-status-column branch from 666e929 to 15cfbd7 Compare July 24, 2024 15:38
@jamiedemaria jamiedemaria force-pushed the jamie/backfill-page-run-status-column branch from 15cfbd7 to 8a60c65 Compare July 25, 2024 18:13
@jamiedemaria jamiedemaria force-pushed the jamie/backfill-page-run-status-column branch 2 times, most recently from 8496ed0 to 1f93860 Compare July 25, 2024 18:55
Base automatically changed from jamie/job-backfill-status to master July 26, 2024 16:44
@jamiedemaria jamiedemaria force-pushed the jamie/backfill-page-run-status-column branch from 1f93860 to f38de78 Compare July 26, 2024 16:45
@jamiedemaria jamiedemaria merged commit 4e4d3dc into master Jul 26, 2024
2 checks passed
@jamiedemaria jamiedemaria deleted the jamie/backfill-page-run-status-column branch July 26, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants