Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Show target in Schedules lists #23270

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

hellendag
Copy link
Member

@hellendag hellendag commented Jul 26, 2024

Summary & Motivation

Use AutomationTargetList in the Schedules and merged Automations lists.

  • Add a column in the Schedules-only lists.
  • Replace the existing pipeline reference in the merged automations list.

Schedule that targets assets:

Screenshot 2024-07-26 at 13 55 42

List of schedules with job targets:

Screenshot 2024-07-26 at 13 50 12

Merged automation table:

Screenshot 2024-07-26 at 14 01 12

How I Tested These Changes

View all schedules lists (overview and per-code location) and merged automation list. Verify correct rendering and behavior of target tag.

Repeat with the anonymous job schedules, verify that they show the asset selection target.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hellendag and the rest of your teammates on Graphite Graphite

Copy link

github-actions bot commented Jul 26, 2024

Deploy preview for dagit-core-storybook ready!

✅ Preview
https://dagit-core-storybook-l8jwc3jhb-elementl.vercel.app
https://dish-schedule-list-show-target.core-storybook.dagster-docs.io

Built with commit ef13814.
This pull request is being automatically deployed with vercel-action

@hellendag hellendag force-pushed the dish/schedule-list-show-target branch 2 times, most recently from 53c4acc to 02f5af9 Compare July 26, 2024 19:02
@hellendag hellendag marked this pull request as ready for review July 26, 2024 19:04
@hellendag hellendag force-pushed the dish/schedule-list-show-target branch from 02f5af9 to ef13814 Compare July 26, 2024 19:12
Copy link
Contributor

@salazarm salazarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to me

@hellendag hellendag merged commit 0268adc into master Jul 29, 2024
2 checks passed
@hellendag hellendag deleted the dish/schedule-list-show-target branch July 29, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants