Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix python packages logic to account for the fact that ls-files doesn't list directories #25045

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

neilfulwiler
Copy link
Contributor

this was an oversight on my part because I thought git ls-files . would include directories. I thought I had verified the resulting packages but I guess was confused because we still traverse explicit packages that are listed. This fixes like in https://app.graphite.dev/github/pr/dagster-io/internal/12014/alerts-fix-build-by-adding-logging-statement-back where we weren't running dagit tests after backend changed

Test Plan

From github.com:dagster-io/dagster
 * branch                  master     -> FETCH_HEAD
2024-10-03 16:06:38 INFO     Changed files between origin/master (b52d3147e8) and HEAD (e51c353592):
2024-10-03 16:06:38 INFO       - python_modules/dagster-webserver/dagster_webserver/graphql.py
2024-10-03 16:06:38 INFO     Finding Python packages:
2024-10-03 16:06:38 INFO       - REPO_NAME_PLACEHOLDER
2024-10-03 16:06:38 INFO       - assets_dbt_python
2024-10-03 16:06:38 INFO       - assets_dynamic_partitions
2024-10-03 16:06:38 INFO       - assets_modern_data_stack
2024-10-03 16:06:38 INFO       - assets_pandas_pyspark
2024-10-03 16:06:38 INFO       - assets_pandas_type_metadata
2024-10-03 16:06:38 INFO       - assets_smoke_test
2024-10-03 16:06:38 INFO       - assets_yaml_dsl
2024-10-03 16:06:38 INFO       - automation
2024-10-03 16:06:38 INFO       - builtin-blueprints
2024-10-03 16:06:38 INFO       - custom-blueprints
2024-10-03 16:06:38 INFO       - dagit
2024-10-03 16:06:38 INFO       - dagster
2024-10-03 16:06:38 INFO       - dagster
2024-10-03 16:06:38 INFO       - dagster-airbyte
2024-10-03 16:06:38 INFO       - dagster-airflow
2024-10-03 16:06:38 INFO       - dagster-airlift
2024-10-03 16:06:38 INFO       - dagster-aws
2024-10-03 16:06:38 INFO       - dagster-azure
...
2024-10-03 16:06:41 INFO     Building dagster-cloud-dagit because of changes to {PythonPackage(dagster-webserver)}
2024-10-03 16:06:41 INFO     Building dagster-cloud-dagit because of changes to {PythonPackage(dagster-webserver)}
2024-10-03 16:06:41 INFO     Building dagster-cloud-dagit because of changes to {PythonPackage(dagster-webserver)}
2024-10-03 16:06:41 INFO     Building dagit because we're building dagster-cloud-dagit

Copy link
Contributor Author

neilfulwiler commented Oct 3, 2024

Merge activity

@neilfulwiler neilfulwiler merged commit f510688 into master Oct 3, 2024
2 checks passed
@neilfulwiler neilfulwiler deleted the fix-python-packages-logic branch October 3, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants