Add resolution parameter to constructor and read method. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlia
added a commit
that referenced
this pull request
Nov 17, 2012
Add resolution parameter to constructor and read method.
dahlia
added a commit
that referenced
this pull request
Nov 17, 2012
dahlia
added a commit
that referenced
this pull request
Nov 17, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a substitute pull request for (#67)
At the other pull-request indicabas that should put the method in the constructor rather read.
To read well the vector formats you need to put the resolution before reading the file. So it's very useful to have the
resolutionparameter in the constructor. So it's easy to keep using python context managers.Also, I added the possibility that resolution is an integer and not a tuple. This emulates the behavior of the parameter "-density" from the command line, and may bring
resolution=300, which actually becomes (300, 300).I added appropriate tests.