Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add density parameter for correct handling density on vectorial images .... #67

Closed
wants to merge 1 commit into from

Conversation

niwinz
Copy link
Contributor

@niwinz niwinz commented Oct 15, 2012

like pdf, svg, etc.

Is same code that #28
As the original author has said it will send the pull request, but has already spent two months since.

All credits to the original creator of the patch, I just need this functionality.

@dahlia
Copy link
Collaborator

dahlia commented Oct 15, 2012

Many things had changed (see #58 — it contains explicit read() method and resolution property which means density), so it should:

  • contain tests for it
  • not declare duplicate MagickSetImageResolution() signature (use Image.resolution property instead)
  • rename density to resolution
  • move the parameter from __init__() to read()

Thanks!

@niwinz
Copy link
Contributor Author

niwinz commented Nov 17, 2012

Hello!
Having the property "resolution", my pull request ceases to have much meaning. But, I think the method is useful resolution, in method "init", besides read.

I will create another smaller pull request with these small changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants