Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-waku): install dependencies automatically when creating a new waku project #808

Merged
merged 36 commits into from
Oct 1, 2024

Conversation

ojj1123
Copy link
Contributor

@ojj1123 ojj1123 commented Jul 28, 2024

follow up #728

  • implement a new feature

Copy link

vercel bot commented Jul 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
waku ✅ Ready (Inspect) Visit Preview Oct 1, 2024 2:42am

Copy link

codesandbox-ci bot commented Jul 28, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@ojj1123
Copy link
Contributor Author

ojj1123 commented Jul 28, 2024

스크린샷 2024-07-29 00 04 45

Some tests fail. I think that some tests of create-waku.spec were outdated due to some new features developed.
I try to add the test in this PR. But I will be busy next week, so if I'm done with my work, then I will work this.

@ojj1123 ojj1123 marked this pull request as draft July 28, 2024 15:16
@ojj1123
Copy link
Contributor Author

ojj1123 commented Aug 9, 2024

bb908ad

I did comment all of changes. All tests pass. From now, I will see what changes lead to fail.

@ojj1123
Copy link
Contributor Author

ojj1123 commented Aug 10, 2024

f1a7a6d

Using spawn, the tests fail on windows.
스크린샷 2024-08-10 11 14 45

@dai-shi
Copy link
Owner

dai-shi commented Aug 10, 2024

Ah, it's a windows only issue...

@ojj1123
Copy link
Contributor Author

ojj1123 commented Aug 10, 2024

I feel like it can be solved if using cross-spawn, but I didn't try to do that yet.

You were like that you don't want to use the external lib, so I try to solve it w/o that lib!

@dai-shi
Copy link
Owner

dai-shi commented Aug 10, 2024

Yes, it's correct that I don't generally want to use external libraries.
I hope you can work it around, but otherwise, using cross-spawn might be acceptable if that's the only reasonable way.

@ojj1123
Copy link
Contributor Author

ojj1123 commented Aug 31, 2024

I don't know why tests fail although I added shell option to true if being on win32. So I'm gonna try to take cross-spawn and then check the test status.

@ojj1123 ojj1123 marked this pull request as draft September 2, 2024 07:44
- folders in .cache take a lot of memories. so it causes "EPIPE: broken pipe, write"
e2e/create-waku.spec.ts Outdated Show resolved Hide resolved
@ojj1123 ojj1123 marked this pull request as ready for review September 14, 2024 15:09
@ojj1123
Copy link
Contributor Author

ojj1123 commented Sep 15, 2024

All tests are passed. Could you review this PR?

Copy link
Owner

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks clean!

Let's wait for @himself65 feedback about the spec.

packages/create-waku/src/index.ts Outdated Show resolved Hide resolved
Copy link
Owner

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

e2e/create-waku.spec.ts Outdated Show resolved Hide resolved
Copy link
Owner

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for your contribution!

@dai-shi dai-shi merged commit 901594c into dai-shi:main Oct 1, 2024
28 checks passed
@ojj1123 ojj1123 deleted the install-deps branch October 1, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants