-
-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(create-waku): install dependencies automatically when creating a new waku project #808
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
I did comment all of changes. All tests pass. From now, I will see what changes lead to fail. |
Ah, it's a windows only issue... |
I feel like it can be solved if using cross-spawn, but I didn't try to do that yet. You were like that you don't want to use the external lib, so I try to solve it w/o that lib! |
Yes, it's correct that I don't generally want to use external libraries. |
I don't know why tests fail although I added shell option to |
- folders in .cache take a lot of memories. so it causes "EPIPE: broken pipe, write"
All tests are passed. Could you review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks clean!
Let's wait for @himself65 feedback about the spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your contribution!
follow up #728