fix(newlines). Remove newline chars in text nodes (\n) when parsing…

… HTML (bustle#478) Fixes bustle#333
dailybeast · Feb 7, 2017 · 85d2fef · 85d2fef
1 parent 06c8e52
commit 85d2fef
Show file tree

Hide file tree

Showing 4 changed files with 93 additions and 238 deletions.
diff --git a/src/js/parsers/section.js b/src/js/parsers/section.js
@@ -44,6 +44,12 @@ const SKIPPABLE_ELEMENT_TAG_NAMES = [
   'style', 'head', 'title', 'meta'
 ].map(normalizeTagName);
 
+const NEWLINES = /\n/g;
+function sanitize(text) {
+  text = text.replace(NEWLINES, '');
+  return text;
+}
+
 /**
  * parses an element into a section, ignoring any non-markup
  * elements contained within
@@ -171,7 +177,7 @@ class SectionParser {
 
   parseTextNode(textNode) {
     let { state } = this;
-    state.text += textNode.textContent;
+    state.text += sanitize(textNode.textContent);
   }
 
   _updateStateFromElement(element) {

diff --git a/tests/helpers/post-abstract.js b/tests/helpers/post-abstract.js
@@ -113,11 +113,7 @@ function parseTextIntoMarkers(text, builder) {
         markers = markers.concat( parseTextIntoMarkers(piece, builder) );
       }
     });
-  } else if (text.indexOf('*') === -1) {
-    if (text.length) {
-      markers.push(builder.marker(text));
-    }
-  } else {
+  } else if (text.indexOf('*') !== -1) {
     let markup = builder.markup('b');
 
     let startIndex = text.indexOf('*');
@@ -133,6 +129,10 @@ function parseTextIntoMarkers(text, builder) {
         markers.push(builder.marker(piece, markups));
       }
     });
+  } else {
+    if (text.length) {
+      markers.push(builder.marker(text));
+    }
   }
 
   return markers;