Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add common headers to all fetch requests #2287

Closed
wants to merge 0 commits into from
Closed

feat: add common headers to all fetch requests #2287

wants to merge 0 commits into from

Conversation

omBratteng
Copy link
Member

@omBratteng omBratteng commented Oct 19, 2023 •
edited
Loading

Changes

Adds the current app version to all requests, which will be used for telemetry and metrics in API

Describe what this PR does

  • adds header X-App-Version to all fetch requests

todo: add header X-App-Version to all graphql requests

https://version-requests.preview.app.daily.dev/

@rebelchris
Copy link
Contributor

@omBratteng Do we still want to do anything with this PR?

@omBratteng
Copy link
Member Author

@omBratteng Do we still want to do anything with this PR?

Yeah, could probably take another look at it

@vercel Vercel
Copy link

vercel bot commented Sep 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 1:13am

@omBratteng omBratteng closed this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omBratteng @rebelchris