Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate event emitter unit tests from mocha to jest #313

Merged
merged 1 commit into from
Oct 14, 2019

Conversation

kobawan
Copy link
Contributor

@kobawan kobawan commented Sep 18, 2019

Description

Migrate unit tests from mocha to jest:

  • event emitter
    - [ ] vast client
    - [ ] vast parser
    - [ ] vast tracker

Migration of other files to split in separate PRs to avoid conflicts due to an increase in contributions to vast-client.

Type

  • Breaking change
  • Enhancement
  • Fix
  • Documentation
  • Tooling

@kobawan kobawan added refactor wip Work in progress 3.0 3.0 roadmap labels Sep 18, 2019
@kobawan kobawan self-assigned this Sep 18, 2019
@kobawan kobawan mentioned this pull request Sep 23, 2019
@kobawan kobawan changed the title WIP: Migrate unit tests from mocha to jest Migrate event emitter unit tests from mocha to jest Oct 11, 2019
@kobawan kobawan removed the wip Work in progress label Oct 11, 2019
@kobawan kobawan added this to the 3.0 milestone Oct 11, 2019
Copy link
Contributor

@ZacharieTFR ZacharieTFR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@kobawan kobawan merged commit d9fcd29 into 3.0-version Oct 14, 2019
@ZacharieTFR ZacharieTFR deleted the mocha-to-jest branch September 29, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0 3.0 roadmap refactor
Development

Successfully merging this pull request may close these issues.

2 participants