Add tool to compare bundle sizes #328
Conversation
kobawan
added
enhancement
chore
| @@ -25,7 +25,9 @@ | |||
| "main": "dist/vast-client-node.min.js", | |||
| "browser": "dist/vast-client.min.js", | |||
| "scripts": { | |||
| "prebuild": "rm -rf dist_old && mkdir dist_old && cp -a dist/. dist_old/", | |||
There was a problem hiding this comment.
Not windows (cmd) proof I think but I'm not sure if it's actually a problem
There was a problem hiding this comment.
I'm not sure how I would make it work on both windows and mac 🤔 is it ok if I leave it as is?
There was a problem hiding this comment.
I guess it's ok like that, there is still ways for windows users to use it, so install the bash from "windows features" (from what I quickly checked on the internet) or use Git bash (what I do)
bundleSize.js
Outdated
| const newSize = newValues[name]; | ||
| const delta = newSize - size; | ||
| const sizeColorFg = delta <= 0 ? '\x1b[32m' : '\x1b[31m'; | ||
| const reset = '\x1b[0m'; |
There was a problem hiding this comment.
I spent some minutes try to figure out what this reset variable stood for, It's maybe only because I'm not used to manipulate colors in console outputs but maybe a naming like "resetColorFg" or something like this would helped me a bit.
There was a problem hiding this comment.
sure I can rename it
Description
It is possible now to compare local bundle size vs last build.
Type