fix(report): do not relativize paths if outdir was not set

marisademeglio · marisademeglio · commit 57b05d9a3c89 · 2017-12-23T22:20:36.000-08:00
This would never be a bug for the user but related tests were failing due to previous commit.
diff --git a/packages/ace-report/src/report-builders.js b/packages/ace-report/src/report-builders.js
@@ -161,7 +161,7 @@ class ReportBuilder {
   }
   withTestSubject(url, title, identifier, metadata, links) {
     var url_ = url;
-    if (this.outdir != "" && reportConfig["use-relative-paths"]) {
+    if (this.outdir !== undefined && this.outdir != "" && reportConfig["use-relative-paths"]) {
       url_ = path.relative(this.outdir, url);
     }
     withTestSubject(this._json, url_, title, identifier, metadata, links);

Original file line number	Diff line number	Diff line change
`@@ -161,7 +161,7 @@ class ReportBuilder {`
`161`	`161`	`}`
`162`	`162`	`withTestSubject(url, title, identifier, metadata, links) {`
`163`	`163`	`var url_ = url;`
`164`		`- if (this.outdir != "" && reportConfig["use-relative-paths"]) {`
	`164`	`+ if (this.outdir !== undefined && this.outdir != "" && reportConfig["use-relative-paths"]) {`
`165`	`165`	`url_ = path.relative(this.outdir, url);`
`166`	`166`	`}`
`167`	`167`	`withTestSubject(this._json, url_, title, identifier, metadata, links);`