Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Most current job status not reflected everywhere when results folder setting is empty #212

Closed
marisademeglio opened this issue Apr 3, 2024 · 23 comments
Closed

Most current job status not reflected everywhere when results folder setting is empty #212

marisademeglio opened this issue Apr 3, 2024 · 23 comments
Milestone
1.4

Comments

@marisademeglio
Copy link
Member

Feedback received from @rachanasinghg
"
Currently I find the status of pipeline jobs a bit confusing, there is somewhat a difference in the Job title tab and result window.
I have attached a few screenshots for your reference.

For example in screenshot DP_Job1 , the result window pane shows Validation completed but the Job tab and status window shows status "Running".
Same goes for DP_Job2, DP_Job3 and DP_Job4 screenshot. The last text/sentence of the result pane does not indicate that Job is completed, or the job title tab should show "Completed" instead of "Running".
We need to check the result folder whether the file is complete or not. For files which have Error , the title also shows the exact thing so it's good but the other files do not show the same.
"
DP_Job1
DP_Job2
DP_Job3
DP_Job4
@marisademeglio
Copy link
Member Author

@rachanasinghg does the status in the tab ever get updated to "Completed"?

@rachanasinghg
Copy link
Collaborator

@rachanasinghg does the status in the tab ever get updated to "Completed"?

Not till now.

@marisademeglio
Copy link
Member Author

@rachanasinghg does the status in the tab ever get updated to "Completed"?

Not till now.

So it never changes to "Completed"?

Has this always been the case for you or is it new behavior?

@rachanasinghg
Copy link
Collaborator

rachanasinghg commented Apr 4, 2024 via email

@marisademeglio
Copy link
Member Author

Ok thanks for the clarification! Can you confirm the version that you're using and the version that you were using when it was working?

@rachanasinghg
Copy link
Collaborator

rachanasinghg commented Apr 4, 2024 via email

@marisademeglio
Copy link
Member Author

Did you have any luck with older installers? Also if these results were with 1.2.7-RC1, maybe we could check with 1.2.7. Can you let me know if that behaves the same?

@marisademeglio marisademeglio added the need-followup-info Additional information is required label Apr 16, 2024
@rachanasinghg
Copy link
Collaborator

rachanasinghg commented Apr 17, 2024 via email

@marisademeglio
Copy link
Member Author

Ok thanks for testing the other versions, we will look into it. @NPavie do you notice this issue on Windows?

@marisademeglio
Copy link
Member Author

I was not able to reproduce this with the upcoming 1.3.0 release after briefly testing it on Windows 11.

@marisademeglio
Copy link
Member Author

@rachanasinghg Can you check with the new release? And if it's still an issue, could you email your log file found at %APPDATA%\pipeline-ui\logs\main.log ?

@rachanasinghg
Copy link
Collaborator

rachanasinghg commented Apr 24, 2024 via email

@NPavie
Copy link
Collaborator

NPavie commented Apr 24, 2024

Hi @rachanasinghg, sorry about that, we will continue to investigate.

Github did not forwarded the log file along your email for the team to look it up.
Can you send it to the team via a separate email to the daisy-pipeline@mail.daisy.org mailing list ?

I notice on the screenshot provided that it was all related to DAISY 2.02 input files, does it also act similarly on other scripts with different input format (like dtbook-based script) ?
Along the log file, could it be possible for you to provide us as a zip file of one of the Daisy2.02 book that is exposing this behaviour ?

@rachanasinghg
Copy link
Collaborator

rachanasinghg commented Apr 24, 2024 •
edited
Loading

Hello @NPavie ,

I have already sent the mail to daisy-pipeline@mail.daisy.org , with 1 Zip file and 2 log files. Zip file has "Alice in wonderland" book which is one of the books throwing errors in conversion. There are 2 log files, file named as old_main contain the Daisy 2 conversion errors, which i had sent through my previous email. The other file named as main_new contains the DAISY 3 conversion errors.

If you are still facing an issue in reading the file, please do let me know.
Thank you.

@NPavie
Copy link
Collaborator

NPavie commented Apr 24, 2024

@rachanasinghg sorry to bother you again, it seems the mail with the attachment did not passed trought the mailing list

Can you try to send it to me to pavie.nicolas@gmail.com ?

@rachanasinghg
Copy link
Collaborator

rachanasinghg commented Apr 24, 2024 via email

@marisademeglio
Copy link
Member Author

@rachanasinghg can you try something? Run a job, wait a bit until when you would expect it to say "completed", and while it still says "running" instead, open this page in a browser:

http://localhost:49152/ws/jobs

and paste the output here. It should be an XML document. It might list nothing or it might list one or more jobs. It can tell us what the pipeline engine is reporting directly, and that might be informative.

@NPavie
Copy link
Collaborator

NPavie commented Apr 25, 2024

@rachanasinghg from the log I might have an idea of what is going on but just to confirm, can you do the following actions in the application ?

  • Can you open the application settings, and give us back the value of the "Results folder" setting in the general section ?
  • Can you select a different result folder using the browse button, close the settings, and then create and launch a new job ?

@rachanasinghg
Copy link
Collaborator

rachanasinghg commented Apr 25, 2024 via email

@rachanasinghg
Copy link
Collaborator

rachanasinghg commented Apr 25, 2024 via email

@NPavie
Copy link
Collaborator

NPavie commented Apr 25, 2024

Ok i was able to reproduce the issue i think (it came from the empty value in the Results folder field)

I'll update the issue name

@NPavie NPavie changed the title Most current job status not reflected everywhere Most current job status not reflected everywhere when results folder setting is empty Apr 25, 2024
NPavie added a commit that referenced this issue Apr 25, 2024
@NPavie
fix(#212): avoid empty download folder in loaded settings
4bd804d 
Added a URL test in settings middleware to avoid empty or invalid download folder on loading the settings file.

Also
- Added some additionnal logging to report errors in the log on downloading results
- Handle a possible case of download results called on a job without results
- Avoid to delete the engine job if it has not been downloaded
@marisademeglio marisademeglio removed the need-followup-info Additional information is required label May 20, 2024
@marisademeglio marisademeglio added this to the 1.4 milestone Jun 1, 2024
@marisademeglio
Copy link
Member Author

I am having issues with this, if I go under settings and clear the Results folder field, and run a job, it gets stuck mid-process.

What's actually happening is that as soon as the job status is SUCCESS and it attempts to download the results, it says

Error downloading job results TypeError [ERR_INVALID_URL]: Invalid URL

this doesn't happen when the Results folder is set.

12:54:58.761 › fetching  http://127.0.0.1:49152/ws/jobs/b741949c-aaf8-465f-bbd8-8774d651541d null
[1] 12:54:58.777 › received job data  {
[1]   jobId: 'b741949c-aaf8-465f-bbd8-8774d651541d',
[1]   status: 'RUNNING',
[1]   href: 'http://127.0.0.1:49152/ws/jobs/b741949c-aaf8-465f-bbd8-8774d651541d',
[1]   nicename: 'DTBook to braille',
[1]   messages: [ 'removed to keep log cleaner' ],
[1]   progress: 0,
[1]   script: {
[1]     id: 'dtbook-to-pef',
[1]     href: 'http://127.0.0.1:49152/ws/scripts/dtbook-to-pef',
[1]     nicename: 'DTBook to braille',
[1]     description: 'Transforms a DTBook (DAISY 3 XML) document into an embosser ready braille document.',
[1]     version: '10.0.1',
[1]     homepage: '',
[1]     inputs: [],
[1]     options: []
[1]   }
[1] }
[1] 12:54:59.765 › fetching  http://127.0.0.1:49152/ws/jobs/b741949c-aaf8-465f-bbd8-8774d651541d null
[1] 12:54:59.797 › received job data  {
[1]   jobId: 'b741949c-aaf8-465f-bbd8-8774d651541d',
[1]   status: 'SUCCESS',
[1]   href: 'http://127.0.0.1:49152/ws/jobs/b741949c-aaf8-465f-bbd8-8774d651541d',
[1]   nicename: 'DTBook to braille',
[1]   log: 'http://127.0.0.1:49152/ws/jobs/b741949c-aaf8-465f-bbd8-8774d651541d/log',
[1]   results: {
[1]     href: 'http://127.0.0.1:49152/ws/jobs/b741949c-aaf8-465f-bbd8-8774d651541d/result',
[1]     mimeType: 'application/zip',
[1]     namedResults: [ [Object] ]
[1]   },
[1]   messages: [ 'removed to keep log cleaner' ],
[1]   progress: 1,
[1]   script: {
[1]     id: 'dtbook-to-pef',
[1]     href: 'http://127.0.0.1:49152/ws/scripts/dtbook-to-pef',
[1]     nicename: 'DTBook to braille',
[1]     description: 'Transforms a DTBook (DAISY 3 XML) document into an embosser ready braille document.',
[1]     version: '10.0.1',
[1]     homepage: '',
[1]     inputs: [],
[1]     options: []
[1]   }
[1] }
[1] 12:54:59.798 › Error downloading job results TypeError [ERR_INVALID_URL]: Invalid URL
[1]     at new NodeError (node:internal/errors:372:5)
[1]     at URL.onParseError (node:internal/url:553:9)
[1]     at new URL (node:internal/url:629:5)
[1]     at /Users/marisa/dev/pipeline-ui/node_modules/.dev-temp-build/main.js:60147:51
[1]     at Array.map (<anonymous>)
[1]     at /Users/marisa/dev/pipeline-ui/node_modules/.dev-temp-build/main.js:60146:164
[1]     at step (/Users/marisa/dev/pipeline-ui/node_modules/.dev-temp-build/main.js:60030:23)
[1]     at Object.next (/Users/marisa/dev/pipeline-ui/node_modules/.dev-temp-build/main.js:59971:20)
[1]     at asyncGeneratorStep (/Users/marisa/dev/pipeline-ui/node_modules/.dev-temp-build/main.js:59849:28)
[1]     at _next (/Users/marisa/dev/pipeline-ui/node_modules/.dev-temp-build/main.js:59867:17)

marisademeglio added a commit that referenced this issue Jun 3, 2024
@marisademeglio
fix(#212): make the results folder a required setting in the dialog
406de7c 
this however does not stop users from leaving it empty; at least they get a warning though.
marisademeglio added a commit that referenced this issue Jun 3, 2024
@marisademeglio
fix(#212): user gets more warnings about empty results folder
5daf41e 
The "Run" and "Re-run" buttons are disabled if there is not a results folder set, and a warning is displayed.
@marisademeglio
Copy link
Member Author

I don't know internally what would have to change in order to run jobs with no results folder specified, but it doesn't seem like desirable behavior so I disabled the ability to run jobs if there is not a results folder set in settings.

@marisademeglio marisademeglio reopened this Jun 3, 2024
marisademeglio added a commit that referenced this issue Jun 3, 2024
@marisademeglio
fix(#212): also enable/disable the "run job" menu item
f806c51 
Depending on settings downloadFolder field being empty or not
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4
Development

No branches or pull requests
3 participants
@marisademeglio @NPavie @rachanasinghg