Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing "Delete job" to "Close job" #81

Closed
bertfrees opened this issue Feb 27, 2023 · 3 comments
Closed

Consider changing "Delete job" to "Close job" #81

bertfrees opened this issue Feb 27, 2023 · 3 comments
Assignees
Milestone

Comments

@bertfrees
Copy link
Member

bertfrees commented Feb 27, 2023

While "Delete job" is a correct description of what happens (should happen) to the job within the engine, it might not be the best from a user perspective. Because the results are automatically stored in the results folder, the user might fear that the results would be deleted too. I can think of the following solutions:

  • Perhaps a better name is "Close job"? Note that when we add persistence in the future, closing a job tab and deleting a job from the engine will be strictly different things anyway.
  • When a job tab is closed we could show a warning that the job is deleted from the engine, but that the results in the results folder are not deleted. (Perhaps it is better to not even mention the engine for now.) There could be a "Don't show this message again" option (and when the whole window with more than one completed jobs in it is closed (#83) there could be an option to confirm once for all jobs).
  • There could be a similar message in the help text / title attribute of the button.
@bertfrees
Copy link
Member Author

Done, but the "close" terminology is not consistently used everywhere yet. E.g.:

  • in the warning messages that are presented before a job is closed
  • in the settings window

@bertfrees
Copy link
Member Author

Shall we reopen this issue? Or create a new one?

@bertfrees
Copy link
Member Author

Reopening it.

@bertfrees bertfrees reopened this Mar 9, 2023
NPavie added a commit that referenced this issue Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants