Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest engine version 1.14.18-SNAPSHOT #211

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

bertfrees
Copy link
Member

No description provided.

@NPavie
Copy link
Collaborator

NPavie commented Apr 8, 2024

@bertfrees this PR breaks the build process on Windows :

There seems to be an issue in the "enable-java-sheel.mk" file in the engine, the ifeq ($(OS),Windows_NT) is not resolved correctly.
(when trying to display the content of the "OS" variable seems empty)

I bypass this by forcing the SHELL variable assignment to the correct launcher

@bertfrees
Copy link
Member Author

@NPavie Not sure what could be the problem. The file was changed in daisy/pipeline-assembly@e277f30. The ifeq ($(OS),Windows_NT) did not change.

@bertfrees bertfrees deleted the engine-1.14.18 branch April 10, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants