Fix collapse checkbox not closing on ios #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tabindex on the component + bring docs inline with daisyui
👷 Deploy Preview for react-daisyui processing.
|
1 similar comment
👷 Deploy Preview for react-daisyui processing.
|
✅ Deploy Preview for react-daisyui ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
benjitrosch
approved these changes
Sep 19, 2022
This was referenced Sep 19, 2022
This was referenced Oct 31, 2022
This was referenced Dec 30, 2022
This was referenced Apr 4, 2023
This was referenced Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component: Collapse
Issue: Collapse checkbox cannot close on mobile browser (os: ios 15.5) (#168)
Fixed the Collapse checkbox not closing on ios while maintaining focusable tabindex on the component and brought docs inline with
daisyuidocumentationI tested this fix on IOS and MacOS both chrome and safari, all the existing behaviour stayed the same and the checkbox works as expected now.