Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

Handling of unexpected interruptions during upload #6

Open
pcaversaccio opened this issue Aug 11, 2022 · 5 comments
Open

Handling of unexpected interruptions during upload #6

pcaversaccio opened this issue Aug 11, 2022 · 5 comments
Assignees
Labels
feature 💥 New feature or request refactor 🛠 Refactoring existing computer code

Comments

@pcaversaccio
Copy link
Member

We should take care of proper error handling after unexpected interruptions (e.g. after hitting ctrl + c) during upload.

The goal should be that everything is uploaded until the breaking point.

@pcaversaccio pcaversaccio added the feature 💥 New feature or request label Aug 11, 2022
@pcaversaccio pcaversaccio added the refactor 🛠 Refactoring existing computer code label Aug 11, 2022
@BEdaita
Copy link
Collaborator

BEdaita commented Sep 4, 2022

Hi Pascal, currently I am reviewing this issue. Because the process when using the library often has two process
Firstly, The library will send information data to the server (create presign URL , validate extension) after that the library gets push data to s3 . If we handle unexpected interruption in step two, I will change workflow and I need to time to investigate.

@pcaversaccio
Copy link
Member Author

@BEdaita I don't think we need to change the workflow right now. What we need to do is to inform the user in the terminal if he/she hits ctrl + c the data will be still pushed to storage if the process is in step two.

@BEdaita
Copy link
Collaborator

BEdaita commented Sep 4, 2022

@pcaversaccio Do you mean we make a notification for the client and continue the process ?

@pcaversaccio
Copy link
Member Author

yes, that's the lowest hanging fruit right now without overengineering everything - but we keep this issue open for later to handle everything properly.

@BEdaita
Copy link
Collaborator

BEdaita commented Sep 4, 2022

Ok, thank you so much. I cleared the issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature 💥 New feature or request refactor 🛠 Refactoring existing computer code
Projects
None yet
Development

No branches or pull requests

2 participants