Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rg-mode-map confilct with evil #78

Closed
glepnir opened this issue Mar 23, 2020 · 4 comments
Closed

rg-mode-map confilct with evil #78

glepnir opened this issue Mar 23, 2020 · 4 comments

Comments

@glepnir
Copy link

glepnir commented Mar 23, 2020

How make it work better with evil?

@dajva
Copy link
Owner

dajva commented Mar 25, 2020

Can you elaborate a bit and be more specific about what problems you see?

@glepnir glepnir closed this as completed Mar 26, 2020
@b3n
Copy link

b3n commented Jul 16, 2020

I have noticed this too. For some reason it pollutes evil-mode-map-alist with rg.el keybindings even when I am in Evil's normal mode. Every other major-mode I use allows me to use Evil's bindings when I am in normal mode, and the major-mode bindings when I am in insert mode. I have looked at the code and I'm not sure what's causing this.

@dajva
Copy link
Owner

dajva commented Aug 30, 2020

rg-mode inherits from compilation-mode so this means (I presume) that the result buffer will end up in evil motion mode. Wonder if that has something to do with it.
But as you say, you see the same in evil normal mode so maybe it's unrelated. Could it just be that some of the key bindings in this package clash with evils?

@dajva dajva reopened this Aug 30, 2020
@dajva
Copy link
Owner

dajva commented Aug 30, 2020

Apart from that there are some obvious conflicts with evil motions. I think l and w are the only one that would have to be redefined to work well with evil motions. w is already deprecated but I can do the same with l and then unbind it after 2.0 release.

dajva added a commit that referenced this issue Sep 5, 2020
This is conflicting with evil-motion-map so let's us 'L' instead.
@dajva dajva closed this as completed in 151f3ed Oct 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants