Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add imenu support #138

Merged
merged 1 commit into from
Apr 27, 2022
Merged

Add imenu support #138

merged 1 commit into from
Apr 27, 2022

Conversation

nbarrientos
Copy link
Contributor

@nbarrientos nbarrientos commented Apr 22, 2022 •
edited
Loading

This changeset sets the buffer-local variable imenu-create-index-function if rg-group-result is enabled, configuring Imenu to list all the matched files and hence allowing to quickly jump to them.

image

Closes #136

@coveralls
Copy link

coveralls commented Apr 23, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-1.08%) to 80.925% when pulling 64e211c on nbarrientos:imenu into 444a8cc on dajva:master.

@dajva
Copy link
Owner

dajva commented Apr 23, 2022

Thanks. Looks good at a glance. I'll have to test this out a bit and review the code early next week.
I also just pushed emacs 28 support to CI so if you could rebase the patch on latest master it would be great.

@nbarrientos
Copy link
Contributor Author

Thanks for looking at the patch. It's rebased now :)

@nbarrientos
Copy link
Contributor Author

I've added a line to the documentation mentioning the Imenu integration.

@dajva
Copy link
Owner

dajva commented Apr 27, 2022

Reviewed now and added some comments. Just some smaller stuff but the doc info link needs fixing before I can merge.

@nbarrientos
Add imenu support
64e211c 
This changeset sets the buffer-local variable
`imenu-create-index-function' if `rg-group-result` is enabled,
configuring Imenu to list all the matched files and hence allowing to
quickly jump to them.

Closes dajva#136
@nbarrientos
Copy link
Contributor Author

Reviewed now and added some comments. Just some smaller stuff but the
doc info link needs fixing before I can merge.

Thanks for reviewing.

I've applied (and rebased) changes to remove the unnecessary setq and to use buffer-substring-no-properties instead.

Regarding the docs I've just added an HTTP link for the time being. Hope it's good enough for now.

@dajva dajva merged commit ace3d41 into dajva:master Apr 27, 2022
@dajva
Copy link
Owner

dajva commented Apr 27, 2022

Super. Thanks a lot. Looking forward to using this myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Imenu support
3 participants
@nbarrientos @coveralls @dajva