Fix typo in description for "all" file types #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 similar comments
|
Coverage is decreased to 0% because Travis is suffering a partial outage. |
|
Thanks |
dajva
pushed a commit
that referenced
this pull request
Oct 7, 2018
As per #41, large buffers don't get fontified/propertized all up front, and wgrep-ag was using the properties set by ag.el/compilation.el to set up wgrep. This led to strange behavior in large ag result buffers, such as not being able to edit results after some number of initial lines because those lines were not propertized yet. This commit completely changes the operation of wgrep-ag. It no longer uses compilation properties (which seemed like a good idea at the time), and instead just uses plain regular expressions from ag output, adding wgrep properties to the whole buffer up front, no matter how large it is. Hopefully my regular expressions cover all the possible cases in ag output! Fixes #41.
dajva
pushed a commit
that referenced
this pull request
Oct 20, 2018
As per #41, large buffers don't get fontified/propertized all up front, and wgrep-ag was using the properties set by ag.el/compilation.el to set up wgrep. This led to strange behavior in large ag result buffers, such as not being able to edit results after some number of initial lines because those lines were not propertized yet. This commit completely changes the operation of wgrep-ag. It no longer uses compilation properties (which seemed like a good idea at the time), and instead just uses plain regular expressions from ag output, adding wgrep properties to the whole buffer up front, no matter how large it is. Hopefully my regular expressions cover all the possible cases in ag output! Fixes #41.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be a stray "gn" in the description, from commit 46716f2