disable tiered compilation for benchmark runs #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm.. I definitely agree for removing the tiered compilation, but I'm unsure about adding the |
|
up to you, I'm happy turning them off for that reasoning (I've never run in production without them, but I'm not most people) |
|
@tcrayford sure, let's leave them out for this and go with the defaults, then I will happily merge this, so thanks! |
|
cool. Do you want me to amend so they're never in the history, or leave the commit in with a note about why? |
|
@tcrayford either way works, whichever is easiest for you :) |
by default, leiningen sets the JVM up for startup time, via tiered compilation (see https://github.com/technomancy/leiningen/wiki/Faster). This doesn't play well with benchmarks, so when running benchmarks, you need to turn off tiered compilation. comparison output (note: not too meaningful, given that most folk running cheshire in production won't be using it on a laptop running os x, but it gives some idea of the difference): https://gist.github.com/tcrayford/1744556933d71f120605
tcrayford
force-pushed
the
use_full_compilation_for_benchmarks
branch
from
520b1c1
to
b253021
Compare
|
history amended. All yours |
dakrone
added a commit
that referenced
this pull request
Feb 1, 2015
disable tiered compilation for benchmark runs
|
Merged, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by default, leiningen sets the JVM up for startup time, via tiered
compilation (see https://github.com/technomancy/leiningen/wiki/Faster).
This doesn't play so well with benchmarks, so when running benchmarks, you
need to turn off tiered compilation. Also nearly every production
jvm runs with AggressiveOpts, UseFastAccessorMethods, and -server, so
enable them too.
comparison output (note: not too meaningful, given that most folk running
cheshire in production won't be using it on a laptop running os x, but
it gives some idea of the difference):
https://gist.github.com/tcrayford/1744556933d71f120605