Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Inverter handling #276

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Refactor: Inverter handling #276

merged 2 commits into from
Apr 30, 2024

Conversation

dalathegreat
Copy link
Owner

What

This PR refactors inverter handling

Why

To simplify the code, and make it easier for new developers to join in

How

We remove the majority of the ifdeffing in the Software.ino file, with clearly defined functions for each inverter:

  • receive_can_inverter();
  • send_can_inverter();
  • update_values_can_inverter();

Cabooman
Cabooman approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@Cabooman Cabooman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dalathegreat dalathegreat merged commit a58c570 into main Apr 30, 2024
48 checks passed
@dalathegreat dalathegreat deleted the refactor/inverter-can-send branch April 30, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cabooman Cabooman Cabooman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dalathegreat @Cabooman