Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow copying text in nodes #38

Closed
PikachuEXE opened this issue Aug 30, 2019 · 6 comments · Fixed by #120
Closed

Allow copying text in nodes #38

PikachuEXE opened this issue Aug 30, 2019 · 6 comments · Fixed by #120

Comments

@PikachuEXE
Copy link

Hi, Thanks again for maintaining this project.

I found that there is no way to copy text from any node
I am trying to copy the index name from it so I can find the existing index and add a new one similar to existing one but more specific (eliminate the "filter" part)

I can see that the pev1 allows that
I understand pev2 has a dragging function which is absent in pev1
But would it be possible to disable that with an option and allow copying?

@pgiraud
Copy link
Member

pgiraud commented Nov 25, 2019

hi @PikachuEXE
Can you please have a try at this testing demo? http://bluecarto.free.fr/pev2/dragscroll
In this demo, I've decided to allow dragging by using the Ctrl key. If you try with the "very large plan" sample, you should see a tip message when you try to scroll horizontally with the scrollbar.
In this demo, you should be able to select texts.
Can you confirm? Does it work for you?

@Krysztophe
Copy link

Some quick comments, as you asked:

  • This is a nice and useful enhancement.
  • Ctrl-A works but indentation is lost (that would be nice, that would make a simplified version of the plan)
  • I can copy & paste the result of a huge plan (50k rows). But scrolling with click+mouse is painfully slow.
  • I have difficulties to un-select after everything is selected : it seems that a double-click on a word is necessary. I would expect a single click in a blank area to enough.
  • I still can't select the 1st line (Execution, time, Planning time...). This is not critical.
  • I find the old dragging old way (click without Ctrl) more natural that Ctrl+click. It depends on what you want. Maybe add a button with a mouse pointer or a hand to choose which mode the user wants? Or assume that a click in a blank area means "scroll", and a click in a node box means "select"?

@PikachuEXE
Copy link
Author

@pgiraud
Thanks for making the demo

  • I can select text (just test a few nodes)
  • A bit difficult to unselect text (through not very critical)
  • Dragging is a bit difficult with Ctrl
    (coz I am on MacOS, Ctrl click = right click, maybe can be fixed)
  • Possible to only allow dragging on background but not on nodes? Or toggle drag mode with a checkbox/whatever?

Thank you for your work :3

@pgiraud
Copy link
Member

pgiraud commented Nov 27, 2019

Thanks @Krysztophe and @PikachuEXE for your relevant feedbacks.
Given that, I decided to explore a different option. And the result is in my opinion much better and less prone to errors.
Please give it a try. You will like too, for sure.
http://bluecarto.free.fr/pev2/dragscroll2

@Krysztophe
Copy link

Perfect!!!

@PikachuEXE
Copy link
Author

Yup, it feels perfect for me too ❤️

@pgiraud pgiraud mentioned this issue Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants