Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Fontbakery tests at build time #36

Open
sladen opened this issue Dec 13, 2017 · 13 comments
Open

Run Fontbakery tests at build time #36

sladen opened this issue Dec 13, 2017 · 13 comments

Comments

@sladen
Copy link
Collaborator

sladen commented Dec 13, 2017

Fontbakery is a set of tests used for validation before on-boarding new releases into Google Fonts.

Ubuntu needs to pass this for normal releases.

Therefore these need to be integrated as validation at build/post-build time.

@madig
Copy link
Contributor

madig commented Dec 16, 2017

In a quick test run, fontbakery complained about the presence of the kern table 😁

@moyogo
Copy link
Contributor

moyogo commented Dec 16, 2017 via email

@madig
Copy link
Contributor

madig commented Dec 17, 2017

Okay :) Not sure if one can upload fonts with that "error" then (the current fonts on GF have it anyway). Ideally we only have one binary build for everything?

Here's the fontbakery output for R: Validationrun-R.txt. Interestingly, FontVal seems to have checks for hdmx, VDMX and LTSH. If these tables turn out to be necessary, I can maybe salvage the code.

@moyogo
Copy link
Contributor

moyogo commented Dec 17, 2017

I'd say fontbakery needs to allow the kern table, exceptionally is OK.

@moyogo
Copy link
Contributor

moyogo commented Dec 17, 2017

Or we produce two sets of fonts.

@anthrotype
Copy link
Contributor

Two sets of fonts is better, the kern table is just dead weight for a web font

@davelab6
Copy link

davelab6 commented Dec 17, 2017 via email

@madig
Copy link
Contributor

madig commented Dec 17, 2017

Oh, that's neat. So why does it complain about e.g. the kern table in fontbakery, or put differently, does the error matter if the optimization is done anyway?

@davelab6
Copy link

davelab6 commented Dec 17, 2017 via email

@madig
Copy link
Contributor

madig commented Dec 17, 2017

But fontbakery check-googlefonts ... complains about the kern table.

@davelab6
Copy link

davelab6 commented Dec 17, 2017 via email

@felipesanches
Copy link

It's a fixed bug ;-)

Thanks @sladen for having reported it!

@felipesanches
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants