Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First iteration on 2nd part blog post #5

Merged
merged 7 commits into from
Aug 31, 2021
Merged

First iteration on 2nd part blog post #5

merged 7 commits into from
Aug 31, 2021

Conversation

damianavila
Copy link
Owner

This is the first draft of the second part of the series, ready for a first pass from @choldgraf 😉 .

@damianavila damianavila mentioned this pull request Aug 26, 2021
Closed
3 tasks
choldgraf
choldgraf approved these changes Aug 27, 2021
View reviewed changes
Copy link
Contributor

@choldgraf choldgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice write-up! I think it's a nice combination of "digging into code" and then zooming out and thinking a little bit. I have a few comments throughout, but in general I think it is pretty clean, esp for a personal blog post

posts/draft2.md Outdated Show resolved Hide resolved
posts/draft2.md Outdated Show resolved Hide resolved
posts/draft2.md Outdated Show resolved Hide resolved
posts/draft2.md Outdated Show resolved Hide resolved
posts/draft2.md Outdated Show resolved Hide resolved
posts/draft2.md Outdated Show resolved Hide resolved
damianavila and others added 5 commits August 30, 2021 11:24
@damianavila @choldgraf
Update posts/draft2.md
ebc90de 
Simplify phrase

Co-authored-by: Chris Holdgraf <choldgraf@gmail.com>
@damianavila @choldgraf
Update posts/draft2.md
d82b388 
Linkify two words instead of just one

Co-authored-by: Chris Holdgraf <choldgraf@gmail.com>
@damianavila @choldgraf
Update posts/draft2.md
a222d8f 
Remove additional article

Co-authored-by: Chris Holdgraf <choldgraf@gmail.com>
@damianavila
Indent paragraphs after numbered list of questions
0a92a6d
@damianavila
Fix negative word
667e1f7
choldgraf
choldgraf reviewed Aug 30, 2021
View reviewed changes
posts/draft2.md Outdated Show resolved Hide resolved
@damianavila @choldgraf
Clarify the question I was asking about
99fe9d3 
Co-authored-by: Chris Holdgraf <choldgraf@gmail.com>
@damianavila
Copy link
Owner Author

OK, I think this one is ready, publishing it by tomorrow morning after conversion to my blog format.

@damianavila damianavila mentioned this pull request Aug 31, 2021
Closed
@damianavila damianavila merged commit 4c2a789 into master Aug 31, 2021
@damianavila damianavila deleted the draft-2 branch August 31, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choldgraf choldgraf choldgraf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@damianavila @choldgraf