This repository has been archived by the owner on Nov 23, 2022. It is now read-only.

Peer review code 07-02 #1

Closed

GiovanniKaaijk opened this issue Feb 7, 2020 · 1 comment

GiovanniKaaijk commented Feb 7, 2020

https://github.com/damian1997/web-app-from-scratch-1920/blob/c25b9438fde7a276b2337614e72f51b1accfc15a/docs/js/app.js#L6

Classmates is a global variable, so there is no need to use it as a param

https://github.com/damian1997/web-app-from-scratch-1920/blob/c25b9438fde7a276b2337614e72f51b1accfc15a/docs/js/app.js#L17

Well done on creating an async loop, you might want to check .map instead of a classic loop.

GiovanniKaaijk changed the title ~~Peer review 07-02~~ Peer review code 07-02

Owner

damianveltkamp commented Feb 14, 2020

Fixed after refactoring

damianveltkamp closed this as completed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.