Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop muted notes to the bottom of list of replies #1522

Closed
alltheseas opened this issue Aug 29, 2023 · 1 comment
Closed

Drop muted notes to the bottom of list of replies #1522

alltheseas opened this issue Aug 29, 2023 · 1 comment
Assignees
@danieldaquino
Labels
enhancement Improvement

Comments

@alltheseas
Copy link
Collaborator

user story

As a Damus user who is browsing a thread full of replies, I would like Damus to move muted notes to the very bottom of all the replies, so I can improve my signal to noise ratio when browsing.

acceptance criteria

  1. Automagically Damus moves notes from muted users to the bottom of reply threads, and
  2. Automagically Damus moves muted notes to the bottom of reply threads.

origin: singal rage
@alltheseas alltheseas added the enhancement Improvement label Aug 29, 2023
@danieldaquino danieldaquino self-assigned this Sep 18, 2023
@danieldaquino
Copy link
Contributor

Implemented this change!

The code changes and testing report were send via email to patches@damus.io, and can be viewed here: https://groups.google.com/a/damus.io/g/patches/c/Hns58kH4FUU

jb55 pushed a commit that referenced this issue Oct 1, 2023
@danieldaquino @jb55
ui: Show muted thread replies at the bottom of the thread view (#1522)
1f942a0 
Testing
-------

**PASS**

**Device:** iPhone 14 Pro simulator
**iOS:** 17.0
**Damus:** This commit
**Steps:**

1. Setup accounts "A" and "B" that you control. Account "A" will be on our device under test.
2. Post something
3. Make a reply using Account A (Reply 1)
4. Make a reply using Account B (Reply 2)
5. Make another reply using account A (Reply 3)
6. Order of replies should be (top to bottom): 1, 2, 3
7. Mute user B
8. Order of replies should be: 1, 3, 2

Performance check
-----------------

**Device:** iPhone 14 Pro simulator
**iOS:** 17.0
**Damus:** This commit
**Steps:**

1. Locally change the code and add a print statement right before the sorting begins. In that print statement, include the number of events that will be sorted
2. Run Damus and go to a busy thread (I found one with 45 replies)
3. Go to the thread, and monitor the logs.
4. Navigate a bit between replies and monitor logs.

**Results:** I only saw a few print statements being printed with each navigation action, which indicates that we are not constantly re-sorting this object (which would be inefficient). Therefore, it seems like performance/efficiency would not be a problem.

Changelog-Changed: Show muted thread replies at the bottom of the thread view (#1522)
Closes: #1522
Signed-off-by: Daniel D’Aquino <daniel@daquino.me>
Reviewed-by: William Casarin <jb55@jb55.com>
Signed-off-by: William Casarin <jb55@jb55.com>
@jb55 jb55 closed this as completed in b86bac2 Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danieldaquino danieldaquino

Labels
enhancement Improvement
Projects
Damus Roadmap 🛣️
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danieldaquino @alltheseas