Intro note submit button doesn't leave screen but posts multiple of the same note

[johnshenio]

The new update on my iPhone 12 pro, iOS 17 with the introduction notes posts multiple of the same button after clicking the submit button. The submit button doesn't leave the post creation screen

I created a new npub but I couldn't get back to the intro note screen

[alltheseas]

Thanks for reporting. I believe this is a duplicate of #1502

[jb55]

I believe this is different

[alltheseas]

Another instance. https://damus.io/note1ur90wv38g06hkqe0kc6wyt6tfnke629u0arxtcsa2fezjswq5yfstn0t9g

https://damus.io/note1grfy7f0g8qgzfym7esg9k92yjqx8rcrqnvgy4c6tga9pzzcq886se5sqqg

[alltheseas]

One more

https://damus.io/note1jnm8m0e39ne78mfgvt4gnhuh54jh3gv7uyqg8pkzf3q0p448r96squlg78

[jb55]

this is really bad

[alltheseas]

https://damus.io/note1v0qrywwy8zul5zmlrvn9z3gy8p8qw8j2tucwksxz26k85nt8wnqsv5uzdk

[alltheseas]

Is it possible to get a quick fix in, or remove this code for now?

cc @danieldaquino

[danieldaquino]

@alltheseas, @jb55, I believe this is precondition dependent.

Two examples:

Device: iPhone 15 Pro simulator
iOS: 17.0
Damus: v1.6 (29) (f976f23854dfddc390bf00095c69d27460c6776d) (Local build)
Behavior: Post view dismissed after posting (works)

Device: iPhone 13 Mini
iOS: 17.1
Damus: v1.6 (29) (f976f23854dfddc390bf00095c69d27460c6776d) (Official build)
Behavior: Post view NOT dismissed after posting

[danieldaquino]

I suspect this might be due to our use of .presentationMode, which upon checking, seems to be deprecated.

https://developer.apple.com/documentation/swiftui/environmentvalues/presentationmode?changes=latest_major

I will check if that's indeed the root cause

[danieldaquino]

Device: iPhone 13 Mini
iOS: 17.1
Damus: v1.6 (29) (f976f23) (Local build)
Behavior: Post view NOT dismissed after posting

[danieldaquino]

Original passing test preconditions (from bf43842)

Device: iPhone 14 Pro simulator
iOS: 17.0
Damus: bf43842

It seems to be failing from iOS 17.1 (based on the data so far)

[danieldaquino]

I suspect this might be due to our use of .presentationMode, which upon checking, seems to be deprecated.

https://developer.apple.com/documentation/swiftui/environmentvalues/presentationmode?changes=latest_major

I will check if that's indeed the root cause

It does not seem to be the only cause. Changing it to the new dismiss() also did not work

[danieldaquino]

@jb55, this is starting to look like one of those obscure SwiftUI bugs.

The relevant factors that determine whether or not the bug occurs seem to be one or many of these:

• iOS version: Tests on 17.0 work as far as I have tested, Tests on 17.1 fail as far as I have tested
• Real device vs. simulator: Simulator works as far as I have tested, real devices do not seem to work as far as I have tested
• View hierarchy: Normal posts seem to be unaffected. However, the exact same post view under the onboarding seems to fail.

In the interest of time, I will send a patch to temporarily disable this onboarding feature

[alltheseas]

this is starting to look like one of those obscure SwiftUI bugs.

Does this experience make the case for UIkit?

[danieldaquino]

this is starting to look like one of those obscure SwiftUI bugs.

Does this experience make the case for UIkit?

Nah, UIKit also has some weird quirks (e.g. the text editor wrapping bugs) LOL

[danieldaquino]

@jb55, I sent an emergency patch for temporarily disabling the feature: https://groups.google.com/a/damus.io/g/patches/c/T6pqnIhJzHc

I will work on a full clean fix tomorrow. I believe the root cause is a combination of:

• Inconsistent behavior of the environment variable .presentationMode between iOS versions or whether the device is real or a simulator (The deprecation might explain the inconsistency)
• The new environment variable .dismiss seems to have limited propagation. It works on OnboardingSuggestionsView, but not on any of its subviews (At least on iOS 17.1 + iPhone 13)

If you could double-check my testing under a different precondition I would appreciate 🙏 (we don't know yet the extent of the inconsistencies around this).

[jb55]

On Thu, Nov 16, 2023 at 08:14:16PM -0800, alltheseas wrote: > this is starting to look like one of those obscure SwiftUI bugs. Does this experience make the case for UIkit?

that would be a huge change, it would take months

[danieldaquino]

@jb55, @alltheseas, sent a patch with the fix!

Root causing, code, fix explanation, and testing report are all in the patch email (Can be viewed here: https://groups.google.com/a/damus.io/g/patches/c/DJ8XymT9mHA)

Important notes:

• I observed another issue (not as bad as this one) on iOS 16. I reported it under a separate ticket: "Who to follow" nav title shows on onboarding post view in iOS 16 #1739
• I made this patch directly on top of the current release. We probably want to create a hotfix branch where we merge in only essential fixes, to avoid regression risk from other recent changes in master
• I tried to test as much and as carefully as possible, but I appreciate any extra independent testing to make sure I did not miss anything 🙏

[jb55]

On Fri, Nov 17, 2023 at 12:11:54PM -0800, Daniel D’Aquino wrote: @jb55, @alltheseas, sent a patch with the fix! Root causing, code, fix explanation, and testing report are all in the patch email (Can be viewed here: https://groups.google.com/a/damus.io/g/patches/c/DJ8XymT9mHA)

awesome, will see if I can get a hotfix out