Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push support? #4

Open
page1 opened this issue Apr 11, 2016 · 2 comments
Open

Push support? #4

page1 opened this issue Apr 11, 2016 · 2 comments

Comments

@page1
Copy link

page1 commented Apr 11, 2016

Hi @dan-da
I've got an update that adds support for a separate audit schema by extending the namespace capabilities. Additionally, the update adds a "snapshot" query to the end of every file generated, this query can be used to take a snapshot of the current state of the source table. This is useful for starting off a new audit table, or catching up a table thats falling out of sync.

It looks like I can't send in my pull request with the current security settings on the repo, if you would like the update please let me know that you've added me.

Thank you so much for putting this together, this tool helped me a lot.

Warning this is my first PHP code, hopefully the update will meet your quality standards, but if not let me know how to improve.

@dan-da
Copy link
Owner

dan-da commented Apr 12, 2016

Hi, thanks for contributing!

To submit your pull request, you should first fork cdc_audit into your own repo and commit your changes there. Usually you should create a unique branch per pull request. Commit your changes to your branch, push, and then submit a pull request from your forked repo on github.

See these two links for detailed instructions:

https://help.github.com/articles/using-pull-requests/
https://gun.io/blog/how-to-github-fork-branch-and-pull-request/

I look forward to reviewing your submission.

@dan-da
Copy link
Owner

dan-da commented Apr 12, 2016

Also, it sounds like the schema support and the snapshot query are distinct features. If at all possible, it would be best to put these into two separate branches and submit a separate pull request for each. This makes it easier to review, and if necessary revert, each feature separately. thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants