compat fixes #93
Merged
compat fixes #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not really useful here since this package has hardly any dependencies
a change of the compat section does not count as just a patch, so we need to increase the minor version of this package to fix it
1 similar comment
|
Thanks @mgkuhn. I must admit that I don't follow the need to restrict the package to Julia 1.4 & 1.5. The unit tests appeared to pass on the older versions, but I have admittedly not smoke tested the current package on the historical releases. I'm still wrapping my head around the new compat specifications and mistakenly excluded the intermediate 1.x releases. I had intended to include all versions from 0.7 to the current 1.5. |
|
Thank you it worked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wavplay(y, fs)does not work #89 and New version: WAV v1.0.4 JuliaRegistries/General#22393)