-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set MSRV to 1.64.0 in package metadata #1343
base: main
Are you sure you want to change the base?
Conversation
clippy respects the rust version set in the package metadata and wouldn't break the build job for newer rust features.
Make sure the line starts with `version` and doesn't pick up `rust-version`.
Hi @nickelc I trust your changes but would you mind spelling out for me exactly what problem this change is solving? |
First it documents the MSRV for readers and then it limits clippy to only issue warnings for lints that are compatible with the MSRV. This reduces the possibility of a broken For example, the
|
This is how the CI job could look like. delta/.github/workflows/ci.yml Lines 111 to 124 in 2c48e35
|
How will I know when to update the MSRV? |
A build job would allow to check PRs against the MSRV #1343 (comment) and then decide to deliberately bump the MSRV. |
It might well be my lack of familiarity with standard Rust practices but my worry is that this is more moving parts to maintain. When I'm in doubt I sometimes look at how bat and ripgrep do things, as examples of Rust CLI projects, so I'll try to do that. |
clippy respects the rust version set in the package metadata and wouldn't break the build job for newer rust features.
The current clap version in use dictates 1.64.0.