Fix alignment in blame mode when author name contains unicode accent modifiers #1456
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue found when an author name contains Unicode modifiers.
For example, the following blame entries:
delta < file.blame
produces (master v0.16.5)It only uses an already embedded crate (unicode_width).
It includes a test case to check the number of trailing spaces with an author's name with or without an accent.
PS: with the suggested fix:
NB: this was the shortest patch I can do. It could be more efficient by only processing extra width for the
author
string (not all strings as it is in the current patch). However, this alternative is possible by setting an extra width insidefield
(the type will be(Cow<str>, usize)
with a default value of0
exceptauthor
: hpwxf@dc38ca9