(13.4.0) INFRASYS-7486 Gives users the option to use autoscaling groups from cloudformation stack #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbraverman
changed the title
| self.project = project.replace('-','') | ||
| self.buildNum = buildNum | ||
| self.buildNum = build_number |
There was a problem hiding this comment.
self.buildNum should be snake_case
sbraverman
force-pushed
the
INFRASYS-7486
branch
7 times, most recently
from
35ad61a
to
eb593b5
Compare
sbraverman
changed the title
sbraverman
force-pushed
the
INFRASYS-7486
branch
2 times, most recently
from
faade63
to
56d5e94
Compare
| AMI ID | ||
| -P PROFILE, --profile PROFILE | ||
| Profile name as designated in aws credentials/config | ||
| files | ||
| -c CONFIG, --config CONFIG | ||
| Config file Location, eg. | ||
| /opt/License2Deploy/config.yml | ||
| -s STACK_NAME, --stack STACK_NAME | ||
| Sack name if AutoScaling Group created via CloudFormation |
sbraverman
force-pushed
the
INFRASYS-7486
branch
from
56d5e94
to
3ce366f
Compare
|
+1 |
sbraverman
force-pushed
the
INFRASYS-7486
branch
from
3ce366f
to
1b16634
Compare
|
+1 |
| return parser.parse_args() | ||
|
|
||
| def main(): # pragma: no cover | ||
| args = get_args() | ||
| SetLogging.setup_logging() | ||
| deployObj = RollingDeploy(args.env, args.project, args.buildNum, args.amiID, args.profile, args.config) | ||
| deployObj = RollingDeploy(args.env, args.project, args.buildNum, args.amiID, args.profile, args.config, args.stack_name) |
There was a problem hiding this comment.
Did we want to change buildNum here (and in get_args) to build_number to be consistent?
|
One comment otherwise +1 |
sbraverman
force-pushed
the
INFRASYS-7486
branch
from
1b16634
to
a6d7e26
Compare
…loudformation stack
sbraverman
force-pushed
the
INFRASYS-7486
branch
from
a6d7e26
to
25fad7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.