DEVOPS-8639: increase wait time limit for instance health check #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taoistmath
reviewed
Mar 27, 2017
| @@ -24,7 +24,7 @@ def __init__(self, | |||
| session=None, | |||
| creation_wait=[10, 60], | |||
| ready_wait=[10, 30], | |||
| health_wait=[10, 30], | |||
| health_wait=[40, 30], | |||
There was a problem hiding this comment.
Rather than changing the default for all projects can we change the default for dnbi-scoring in the jenkins job? https://github.com/dandb/jenkins-jobs/blob/release-next/ami_workflow.dsl#L16
There was a problem hiding this comment.
@taoistmath Excellent. Thank you! Closing this PR now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increased the maximum wait time for health check to 20 minutes as some services such as
scoringtakes longer than 5 minutes to be ready. This shouldn't affect existing deployment.