Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVOPS-12330: adds check for ASG size of 0 #53

Merged
merged 1 commit into from
May 17, 2019

Conversation

taoistmath
Copy link
Contributor

@taoistmath taoistmath commented May 16, 2019

Tested by updating ciq on saltmaster to point to this branch, then highstated ciq agent:

----------
          ID: License2Deploy
    Function: pip.installed
        Name: git+https://github.com/taoistmath/License2Deploy.git@DEVOPS-12330
      Result: True
     Comment: All packages were successfully installed
     Started: 15:53:25.425225
    Duration: 2087.694 ms
     Changes:   
              ----------
              git+https://github.com/taoistmath/License2Deploy.git@DEVOPS-12330==???:
                  Installed

Then ran verified-service_qa_deploy_ami which has ASG desired capacity set to 0 and saw immediate failure:
Screen Shot 2019-05-16 at 4 03 21 PM

passing Travis build:
Screen Shot 2019-05-17 at 10 52 51 AM

Testing evidence that my changes are being tested:
Screen Shot 2019-05-17 at 1 59 35 PM

@coveralls
Copy link

coveralls commented May 16, 2019

Coverage Status

Coverage decreased (-2.6%) to 94.314% when pulling 0382e2c on taoistmath:DEVOPS-12330 into 7b0b0df on dandb:master.

@taoistmath taoistmath force-pushed the DEVOPS-12330 branch 3 times, most recently from b3f1364 to eaaf94d Compare May 17, 2019 18:32
@taoistmath taoistmath merged commit 38ccae7 into dandb:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants