Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve formatting of sizes in web view #11

Closed
jwodder opened this issue Jan 29, 2024 · 2 comments · Fixed by #80
Closed

Improve formatting of sizes in web view #11

jwodder opened this issue Jan 29, 2024 · 2 comments · Fixed by #80
Labels
easy Not hard ui:web Relating to the web interface

Comments

@jwodder
Copy link
Member

jwodder commented Jan 29, 2024

Currently, sizes of assets, versions, etc. are displayed in the web view as just plain integers. The display could be improved in either of the following ways:

  • Add spaces or commas as thousands separators (and probably also right-align the numbers)
  • Format as a number of KiB/MiB/GiB
    • Tera has a filesizeformat filter for doing this, though it seems to use ambiguous "MB"-style abbreviations
@jwodder jwodder added enhancement New feature or request therefor ui:web Relating to the web interface under consideration Dev has not yet decided whether or how to implement labels Jan 29, 2024
@jwodder jwodder added the easy Not hard label Feb 14, 2024
@jwodder
Copy link
Member Author

jwodder commented Feb 15, 2024

@yarikoptic Do you have a preference about how to do this? Personally, I'd prefer just showing the full numbers with spaces as thousands separators, but a lot of people seem to like "12.3 MiB"-style displays.

@yarikoptic
Copy link
Member

I got used to the ones we have on https://datasets.datalad.org/ , e.g. 62.8 GB. So overall preference -- "humanized". I rarely see *iB notation but ok with it as well ;-)

@jwodder jwodder removed under consideration Dev has not yet decided whether or how to implement enhancement New feature or request therefor labels Feb 16, 2024
jwodder added a commit that referenced this issue Feb 16, 2024
Format sizes in the web view in "1.23 MiB" style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Not hard ui:web Relating to the web interface
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants