conservative fork with some essential patches #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missing project.properties file
Use gradle to build
…der already present exception' is thrown (with Content-Length = 0)
…der already present exception' is thrown (with Content-Length = 0)
…gth header already present exception' is thrown (with Content-Length = 0)
This introduces an option to control whether the current playlist is displayed when the album cover is tapped on the Now Playing screen. This option is enabled by default, so the previous behavior is not changed. Disabling this option makes it easier to access the fading button panel at the bottom of the cover.
…irectory instead of getAlbum. For some reason, subsonic server can't find an album with specified ID in getAlbum endpoint, but finds it fine with getMusicDirectory endpoint, so we will go with it.
…download to finish (5 secs -> 10 secs)
This combines the two thumbs up and thumbs down buttons to a single rating button on the now playing screen. Instead of assingning 1 or 5 stars directly, it will open the rating dialog for the song. The setting will default to the current behavior: show two buttons. Fixes daneren2005#1103
it feels like a bug with the default being off
This workflow reuses already existing in repo debug key in debug.keystore. I understand that this key can be used by anyone to sign any apk, but I don't think it should bother us. On our side this key is only going to be used for signing CI builds, so an malefactor could use this key only to replace installed from CI artifact DSUB to a malicous DSUB, I think it's unlikely somebody going to target this. Especially after we get DSub2000 to fdroid. Additionally, this would allow for third-party forks to provide builds, compatible with ours. Thus allowing for users to switch between forks of their choice, if desired. Also, it appers step setup-android isn't required, the flow works without it, so deleting it.
Enable logging in jupnp for debug builds Use kryo lib from maven repo. Bump kryo version from 2.21 to 5.6.0 Add exceptions to log for kryo's exceptions handling
so we can do a release
to make it somewhat useful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these patches are quite self-contained and generally make sense to have to me
from #903 #912 #919
fixes #778 fixes #910 fixes #655