-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of file-embed link. #640
Conversation
Based heavily on code by @syjer whom I'm indebted to. Thanks. Still todo: + Prevent duplicate file embeds. Possibly create a map of uris to PDComplexFileSpecification and reuse if encountered again. I have to peruse the PDF spec to see if this is allowed. + Logging on fail.
Thank you @danfickle , I'll close the old PR :) |
OK, here is a valid file embed link for PDF/A3 standards: <a href="file-embed.html"
download="source.html"
data-content-type="text/html"
title="File embedded"
relationship="Source">
Link to source code
</a> The attributes are:
NOTE: If the Useful links in writing this implementation: |
@danfickle I tried multiple ways to hide the tag but all of them were failing. Also i tried to have an empty tag
but this also didn't work and generated PDF didn't contain the expected attachment. |
Hello, does it work in fast mode? It only works for me in slow mode. In fast mode I can see these logs:
The PDF is created and the link is rendered, but it's not clickable. |
Ok, figured it out. The
and then configured the pdf renderer to use it:
Now it works fine. |
#508 #509 #636
Based heavily on code by @syjer whom I'm indebted to. Thanks.
Still todo: