Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update_Mean_Threshold #1083

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Update_Mean_Threshold #1083

merged 2 commits into from
Mar 23, 2023

Conversation

leowlima
Copy link
Contributor

Describe your changes
Changed from print to plot

Type of update
Is this a:

  • Update to documentation

Associated issues
#999

Additional context
Add any other context about the problem here.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@leowlima leowlima added the documentation Documentation issues or features label Mar 22, 2023
Copy link
Contributor

@Stylopidae1793 Stylopidae1793 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #1083 (279063b) into main (1ca35a3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #1083   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          141       141           
  Lines         6003      6003           
=========================================
  Hits          6003      6003           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@nfahlgren nfahlgren merged commit 047c66f into main Mar 23, 2023
@nfahlgren nfahlgren deleted the mean_threshold branch March 23, 2023 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation issues or features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants