Change None values to none strings #1442
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
In the function
plantcv.plantcv.utils.json2csv
the unique values for a list of metadata values is computed but fails when one or more of the values isNone
. This PR changes theNone
values to a"none"
string, which is the default metadata value.Thanks to @leowlima for reporting the issue!
Type of update
Is this a: Bug fix
Additional context
A better long-term solution would be to set the values to the default value instead of
None
.For the reviewer
See this page for instructions on how to review the pull request.
plantcv/mkdocs.yml
updating.md